Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Parrots extension for op ChamferDistance #2189

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

CokeDong
Copy link
Contributor

@CokeDong CokeDong commented Aug 11, 2022

Support Parrots extension for op ChamferDistance

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2022

CLA assistant check
All committers have signed the CLA.

@CokeDong CokeDong force-pushed the parrots_ChamferDistance branch from 77c928e to 1d4e088 Compare August 11, 2022 06:47
@CokeDong CokeDong force-pushed the parrots_ChamferDistance branch from 1d4e088 to 35fa29d Compare August 11, 2022 06:54
Copy link
Contributor

@luopeichao luopeichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida requested a review from grimoire August 14, 2022 02:56
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne
Copy link
Collaborator

Hi @CokeDong,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@zhouzaida zhouzaida merged commit 595c2eb into open-mmlab:master Aug 15, 2022
zhouzaida pushed a commit that referenced this pull request Aug 18, 2022
* Support Parrots extension for op ChamferDistance

* Fix lint

* Adapt op backward error of IntTensor for parrots

* Fix Lint
zhouzaida pushed a commit that referenced this pull request Aug 18, 2022
* Support Parrots extension for op ChamferDistance

* Fix lint

* Adapt op backward error of IntTensor for parrots

* Fix Lint
@OpenMMLab-Assistant001
Copy link

Hi @CokeDong !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants